DEAR LIZA that's a clean room!! Did you say OSB?? Or OCD....... :biggrin2:
Jk, looks good man.
So since it's upstairs, I assume the underlayment is just to add an additional layer of sound control and cushioning..?
I just don't see why a moisture barrier would be needed for the second floor...
But I guess you're not using it for that since you're putting the plastic film side up rather than down? It probably does make the planks slide a little easier into place. Not sure if that's worth the additional cost of material for that benefit though, but hey to each their own!
If it IS for additional sound protection on top of the OSB, I think you do want to overlap the seams so sound doesn't escape quite as easily through the gap. Tape would probably help in that respect, although I can't imagine it being necessary to tape both sides of the seam to get the same effect.
As far as the unevenness caused by overlapping the felt, I think once all the boards are clicked together and the underlayment and OSB compress with the weight of the floor itself and people walking on it, there shouldn't be any issue with humps or boards popping out. You might've noticed how you'll be working on a row and the boards in that row will have just slight incline to it from when you angled the boards to click in to the previous row. And it stays inclined until the next row of boards is tapped in, and then the next row after that, and pretty soon after 2 or 3 rows are done, the incline is gone. It settles and the felt beneath it compresses and it's even steven.
Now, if it was a pebble or something, then yeah that could pose a problem. But not some thin felt with moisture barrier attached. I mean really, how thick is it after stepping on it? a 10th of an inch at most? Shoot, splinters sit higher than that!
In any case, floor looks good man. I'm liking the color. Kudos on the cleanliness too. That's just plain ol' good practice right there!