Thanks, it just makes me weary about switching cause like I said the light and switch work perfectly, no issues I've just never seen a single pole switch wired with both black wires nutted up and both white wires wired to switch. Also with my general knowledge of wiring I've never seen no voltage on a switch with it on but as soon as you turn the switch off you instantly get 120 volts. I appreciate everyone's help.
From your statements it appears that you are reading 120 V (140 V [?]) across the switch connections/contacts when it is turned off - which is normal, except that you should not read much more than 120V so check your meter, as suggested by jmon.
While I am surprised that no one has yet suggested it, (with the switch turned on) you should take a reading between the switch connections and the "Earth" at the switch/box - assuming that there is one. If you read 120 V (or there abouts), it means that the white wire is connected to the "Line" (Hot) side of the supply and, hence, the Black is (presumably) connected to the "Neutral" - which is incorrect.
If you read zero (or there abouts) it means that the light is being switched via the "Neutral" - which is also incorrect.
(In the latter case, you should expect to read 120 V between the Black wires [after you switch off the breaker, remove the wire-nut and switch on the breaker] and the Earth.)