Ideally all plastic, rubber, or other non-metal parts should be removed before soldering although often this is not possible. A faucet or hose bibb or in line valve that is soldered (sweated) on should be in the open position.
The advent of lead free solder has increased the chance of damage to valves and other fittings during soldering. Electronic solder, which has a lower melting point, is safer for the valves and fittings although that joint would have a tendency to come apart at the moment another nearby joint was soldered using regular plumbing solder.
The good conscientious technician or serviceperson will carry extra oils and lubricants in case the new pump did not come with oil or the oil was accidentally spilled, so the service call can be completed without an extra visit.
The Following User Says Thank You to AllanJ For This Useful Post: